Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: update pre-commit #207

Merged
merged 10 commits into from
Apr 28, 2021
Merged

CI: update pre-commit #207

merged 10 commits into from
Apr 28, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 27, 2021 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Update recommit config and enable CI automation

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added enhancement New feature or request test / CI testing or CI labels Apr 27, 2021
@Borda Borda requested a review from edenlightning as a code owner April 27, 2021 17:26
@codecov
Copy link

codecov bot commented Apr 27, 2021 •
edited
Loading

Codecov Report

Merging #207 (9c9aa54) into master (cceced6) will decrease coverage by 8.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   96.66%   88.22%   -8.44%     
==========================================
  Files         180      180              
  Lines        5750     5740      -10     
==========================================
- Hits         5558     5064     -494     
- Misses        192      676     +484
Flag Coverage Δ
Linux 79.75% <ø> (ø)
Windows 79.75% <ø> (ø)
cpu 79.75% <ø> (-16.91%) ⬇️
gpu 96.66% <ø> (ø)
macOS 79.75% <ø> (-16.91%) ⬇️
pytest 88.22% <ø> (-8.44%) ⬇️
python3.6 ?
python3.8 ?
python3.9 ?
torch1.3.1 ?
torch1.4.0 ?
torch1.8.1 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/utilities/distributed.py 22.85% <0.00%> (-74.29%) ⬇️
torchmetrics/classification/auc.py 47.61% <0.00%> (-52.39%) ⬇️
torchmetrics/metric.py 55.31% <0.00%> (-40.02%) ⬇️
torchmetrics/functional/classification/auroc.py 46.15% <0.00%> (-40.01%) ⬇️
torchmetrics/functional/regression/psnr.py 60.60% <0.00%> (-36.37%) ⬇️
torchmetrics/functional/classification/accuracy.py 57.57% <0.00%> (-36.37%) ⬇️
...chmetrics/functional/classification/stat_scores.py 66.66% <0.00%> (-33.34%) ⬇️
...rics/functional/classification/confusion_matrix.py 66.66% <0.00%> (-33.34%) ⬇️
torchmetrics/utilities/checks.py 60.54% <0.00%> (-31.90%) ⬇️
torchmetrics/functional/classification/f_beta.py 73.91% <0.00%> (-26.09%) ⬇️
... and 222 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cceced6...9c9aa54. Read the comment docs.

@Borda Borda mentioned this pull request Apr 28, 2021
Merged
4 tasks
@Borda Borda added the Priority Critical task/issue label Apr 28, 2021
Borda
Borda commented Apr 28, 2021
View reviewed changes
@Borda Borda requested a review from tchaton April 28, 2021 15:49
carmocca
carmocca reviewed Apr 28, 2021
View reviewed changes
Borda and others added 2 commits April 28, 2021 18:50
@Borda @carmocca
Update .pre-commit-config.yaml
4f33ad4 
Co-authored-by: Carlos Mocholí <[email protected]>
@Borda @carmocca
Update .pre-commit-config.yaml
6d43b59 
Co-authored-by: Carlos Mocholí <[email protected]>
@Borda Borda requested a review from carmocca April 28, 2021 16:50
@Borda Borda enabled auto-merge (squash) April 28, 2021 17:32
@Borda Borda disabled auto-merge April 28, 2021 17:32
@Borda Borda enabled auto-merge (squash) April 28, 2021 17:32
@Borda Borda disabled auto-merge April 28, 2021 17:50
@Borda Borda merged commit 6e33ab0 into master Apr 28, 2021
@Borda Borda deleted the ci/pre-commit branch April 28, 2021 17:51
Borda added a commit that referenced this pull request Apr 28, 2021
@Borda @carmocca @pre-commit-ci
CI: update pre-commit (#207)
452ccd8 
* update pre-commit

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>
SkafteNicki added a commit that referenced this pull request May 4, 2021
@tchaton @pre-commit-ci
@SkafteNicki @Borda @carmocca
[bugfix] MetricCollection should return metrics with prefix on items(…
67ce961 
…), keys() (#209)

* update

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update print

* resolve flake8

* update

* CI: update pre-commit (#207)

* update pre-commit

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>

* fix setup imports (#208)

* fix setup imports

* pkg

* chlog

* format

* update

* update

* check type

* update on comments

* update on comments

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: jirka <[email protected]>
Borda pushed a commit that referenced this pull request May 10, 2021
@tchaton @Borda
[bugfix] MetricCollection should return metrics with prefix on items(…
08bb6df 
…), keys() (#209)

* update

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update print

* resolve flake8

* update

* CI: update pre-commit (#207)

* update pre-commit

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Carlos Mocholí <[email protected]>

* fix setup imports (#208)

* fix setup imports

* pkg

* chlog

* format

* update

* update

* check type

* update on comments

* update on comments

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Nicki Skafte <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: jirka <[email protected]>
(cherry picked from commit 67ce961)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton

@carmocca carmocca Awaiting requested review from carmocca

Assignees
No one assigned
Labels
enhancement New feature or request Priority Critical task/issue test / CI testing or CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Borda @carmocca @tchaton @SkafteNicki