Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for extended summary in MeanAveragePrecision #1983

Merged
merged 8 commits into from
Aug 8, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Aug 7, 2023

What does this PR do?

Fixes #1938
These stats are already computed, so this is just giving the user the possibility to get them.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1983.org.readthedocs.build/en/1983/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Aug 7, 2023
@SkafteNicki SkafteNicki added this to the v1.1.0 milestone Aug 7, 2023
@mergify mergify bot added the has conflicts label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1983 (b73cc01) into master (c6156b0) will decrease coverage by 48%.
The diff coverage is 95%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1983     +/-   ##
========================================
- Coverage      86%     39%    -48%     
========================================
  Files         266     266             
  Lines       15198   15205      +7     
========================================
- Hits        13142    5865   -7277     
- Misses       2056    9340   +7284     

@Borda Borda enabled auto-merge (squash) August 7, 2023 19:51
@mergify mergify bot added the ready label Aug 7, 2023
@Borda Borda merged commit 106c51e into master Aug 8, 2023
@Borda Borda deleted the feature/extended_summary branch August 8, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to Retrieve Precision, Recall, and Confusion Matrix scores from MeanAveragePrecision metric
3 participants