Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for int input for samplewise classification #1977

Merged
merged 7 commits into from
Aug 7, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Aug 5, 2023

What does this PR do?

Fixes #1970
Missing dtype conversion to make sure that for multidim_average="samplewise" works with int input.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1977.org.readthedocs.build/en/1977/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Aug 5, 2023
@SkafteNicki SkafteNicki added this to the v1.0.x milestone Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #1977 (3256356) into master (b22ca97) will decrease coverage by 34%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1977     +/-   ##
========================================
- Coverage      85%     51%    -34%     
========================================
  Files         266     266             
  Lines       15183   15185      +2     
========================================
- Hits        12840    7687   -5153     
- Misses       2343    7498   +5155     

@mergify mergify bot added the ready label Aug 5, 2023
@Borda Borda enabled auto-merge (squash) August 7, 2023 09:16
@mergify mergify bot added the has conflicts label Aug 7, 2023
@mergify mergify bot removed the has conflicts label Aug 7, 2023
@mergify mergify bot added the ready label Aug 7, 2023
@Borda Borda merged commit 51b9047 into master Aug 7, 2023
@Borda Borda deleted the bugfix/classification_int_samplewise branch August 7, 2023 19:48
Borda pushed a commit that referenced this pull request Aug 8, 2023
Borda pushed a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
3 participants