Fix missing AUC score when plotting #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
added
bug / fix
SkafteNicki
requested review from
Borda,
justusschock and
stancld
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1948 +/- ##
========================================
- Coverage 85% 49% -36%
========================================
Files 265 265
Lines 15136 15136
========================================
- Hits 12878 7431 -5447
- Misses 2258 7705 +5447 |
Borda
approved these changes
Jul 28, 2023
justusschock
approved these changes
Aug 3, 2023
Borda
pushed a commit
that referenced
this pull request
Aug 3, 2023
(cherry picked from commit 7cda67c)
Borda
pushed a commit
that referenced
this pull request
Aug 3, 2023
(cherry picked from commit 7cda67c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1941
The AUC score was not added to the appropriate plots even when user specified
score=True. Fixes this.Also fixed the examples in the different docstrings as these were just copy paste and therefore wrong.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--1948.org.readthedocs.build/en/1948/