Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RelativeSquaredError #1765

Merged
merged 26 commits into from
May 11, 2023
Merged

Add RelativeSquaredError #1765

merged 26 commits into from
May 11, 2023

Conversation

wbeardall
Copy link
Contributor

@wbeardall wbeardall commented May 8, 2023

What does this PR do?

Fixes #1764
This PR provides functional and Module-style implementations for the scale-invariant RelativeSquaredError metric.

  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #1765 (c50aa0f) into master (47c6d1c) will increase coverage by 0%.
The diff coverage is 98%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1765   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         251     253    +2     
  Lines       14095   14146   +51     
======================================
+ Hits        12320   12370   +50     
- Misses       1775    1776    +1     

@Borda Borda changed the title Add torchmetrics.regression.RelativeSquaredError Add RelativeSquaredError May 9, 2023
src/torchmetrics/functional/regression/rse.py Outdated Show resolved Hide resolved
src/torchmetrics/functional/regression/rse.py Outdated Show resolved Hide resolved
src/torchmetrics/regression/rse.py Show resolved Hide resolved
@mergify mergify bot added the ready label May 9, 2023
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, two minor suggestions :)

src/torchmetrics/functional/regression/rse.py Outdated Show resolved Hide resolved
src/torchmetrics/functional/regression/rse.py Show resolved Hide resolved
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, two minor suggestions :)

@justusschock justusschock self-requested a review May 9, 2023 15:41
@Borda Borda enabled auto-merge (squash) May 9, 2023 16:27
@mergify mergify bot removed the ready label May 9, 2023
@SkafteNicki SkafteNicki added this to the v1.0.0 milestone May 10, 2023
@mergify mergify bot added the ready label May 10, 2023
@Borda Borda merged commit 3ea6062 into Lightning-AI:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add torchmetrics.regression.RelativeSquaredError
4 participants