-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RelativeSquaredError
#1765
Add RelativeSquaredError
#1765
Conversation
…(RSE). Added MetricTester-derived tests.
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1765 +/- ##
======================================
Coverage 87% 87%
======================================
Files 251 253 +2
Lines 14095 14146 +51
======================================
+ Hits 12320 12370 +50
- Misses 1775 1776 +1 |
torchmetrics.regression.RelativeSquaredError
RelativeSquaredError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, two minor suggestions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, two minor suggestions :)
Co-authored-by: Justus Schock <[email protected]>
for more information, see https://pre-commit.ci
…to wbeardall/master
for more information, see https://pre-commit.ci
What does this PR do?
Fixes #1764
This PR provides functional and Module-style implementations for the scale-invariant
RelativeSquaredError
metric.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃