Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plotting 17/n #1650

Merged
merged 14 commits into from
Mar 31, 2023
Merged

Add plotting 17/n #1650

merged 14 commits into from
Mar 31, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes part of #1406
Adds plot to remaining text metrics

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Mar 24, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 24, 2023
@mergify mergify bot requested a review from a team March 24, 2023 11:56
@Borda Borda enabled auto-merge (squash) March 28, 2023 15:05
@SkafteNicki SkafteNicki requested a review from tchaton as a code owner March 28, 2023 15:18
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1650 (19103fa) into master (d029525) will decrease coverage by 0%.
The diff coverage is 82%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1650   +/-   ##
======================================
- Coverage      89%     89%   -0%     
======================================
  Files         228     228           
  Lines       12450   12502   +52     
======================================
+ Hits        11030   11071   +41     
- Misses       1420    1431   +11     

@Borda Borda disabled auto-merge March 31, 2023 06:20
@mergify mergify bot added the ready label Mar 31, 2023
@Borda Borda merged commit b5ac44e into master Mar 31, 2023
@Borda Borda deleted the plot/17 branch March 31, 2023 08:25
@mergify mergify bot removed the ready label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants