Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Python3 in pre-commit-config.yaml #1463

Merged
merged 4 commits into from
Jan 26, 2023
Merged

Change Python3 in pre-commit-config.yaml #1463

merged 4 commits into from
Jan 26, 2023

Conversation

jxtngx
Copy link
Contributor

@jxtngx jxtngx commented Jan 26, 2023

What does this PR do?

Changes Python default version to Python3 in pre-commit-config.yaml to allow contributors to use Python >= 3.7

Before submitting

  • Was this discussed/approved via a Github issue? (Discussed in Slack with Jirka)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Borda
Borda approved these changes Jan 26, 2023
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
Borda
Borda reviewed Jan 26, 2023
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@Borda Borda changed the title Change Python version to Python3 in pre-commit-config.yaml Change Python3 in pre-commit-config.yaml Jan 26, 2023
@Borda Borda merged commit 662a2a2 into Lightning-AI:master Jan 26, 2023
@mergify mergify bot added the ready label Jan 26, 2023
Borda pushed a commit that referenced this pull request Jan 30, 2023
@jxtngx @Borda
Change Python3 in pre-commit-config.yaml (#1463)
fca8d74 
* simple python version
* ruff update
* Apply suggestions from code review

Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit 662a2a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki SkafteNicki is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@tchaton tchaton Awaiting requested review from tchaton

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxtngx @Borda