Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignore_index in jaccard index #1386

Merged
merged 11 commits into from
Feb 27, 2023
Merged

Fix ignore_index in jaccard index #1386

merged 11 commits into from
Feb 27, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Dec 10, 2022

What does this PR do?

Fixes #1385

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Dec 10, 2022
@SkafteNicki SkafteNicki added this to the v0.12 milestone Dec 10, 2022
@Borda Borda force-pushed the bugfix/multiclass_jaccard branch from 6652c55 to 34466d7 Compare December 14, 2022 13:37
@Borda
Copy link
Member

Borda commented Dec 23, 2022

@SkafteNicki is this ready for review? 🐰

@SkafteNicki SkafteNicki changed the title Fix ignore_index in multiclass jaccard Fix ignore_index in jaccard index Feb 24, 2023
@SkafteNicki SkafteNicki marked this pull request as ready for review February 24, 2023 14:48
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #1386 (da770de) into master (2850524) will decrease coverage by 37%.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1386     +/-   ##
========================================
- Coverage      87%     50%    -37%     
========================================
  Files         219     219             
  Lines       11528   11531      +3     
========================================
- Hits        10007    5776   -4231     
- Misses       1521    5755   +4234     

@mergify mergify bot added the ready label Feb 24, 2023
@Borda Borda enabled auto-merge (squash) February 24, 2023 19:39
@mergify mergify bot removed the ready label Feb 24, 2023
@Borda Borda requested a review from a team February 24, 2023 21:42
@mergify mergify bot added ready and removed has conflicts labels Feb 27, 2023
@Borda Borda merged commit 18aa8da into master Feb 27, 2023
@Borda Borda deleted the bugfix/multiclass_jaccard branch February 27, 2023 16:20
Borda pushed a commit that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MulticlassJaccardIndex: wrong result with ignore_index
3 participants