Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compute_on_cpu arg + forward method #1333

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Fix compute_on_cpu arg + forward method #1333

merged 3 commits into from
Nov 14, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Nov 13, 2022

What does this PR do?

Fixes #1323

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Nov 13, 2022
@SkafteNicki SkafteNicki added this to the v0.10 milestone Nov 13, 2022
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Merging #1333 (a98af3b) into master (3636182) will decrease coverage by 0%.
The diff coverage is 75%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1333   +/-   ##
======================================
- Coverage      87%     87%   -0%     
======================================
  Files         200     200           
  Lines       11472   11476    +4     
======================================
+ Hits         9957    9960    +3     
- Misses       1515    1516    +1     

@Borda Borda enabled auto-merge (squash) November 13, 2022 18:48
@mergify mergify bot added the ready label Nov 13, 2022
@Borda Borda merged commit 3188728 into master Nov 14, 2022
@Borda Borda deleted the bugfix/compute_on_cpu branch November 14, 2022 08:54
@jpcbertoldo
Copy link

Thanks @SkafteNicki!

@SkafteNicki
Copy link
Member Author

@jpcbertoldo thanks for reporting such issues :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compute_on_cpu=True not respected
4 participants