-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for classwise wrapper compute logic #1225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
justusschock,
tchaton and
ethanwharris
as code owners
September 15, 2022 07:14
SkafteNicki
changed the title
Bugfix/classwise wrapper forward
Bugfix for classwise wrapper compute logic
Sep 15, 2022
Codecov Report
@@ Coverage Diff @@
## master #1225 +/- ##
========================================
- Coverage 86% 37% -48%
========================================
Files 191 191
Lines 11319 11325 +6
========================================
- Hits 9699 4235 -5464
- Misses 1620 7090 +5470 |
Borda
approved these changes
Sep 15, 2022
justusschock
approved these changes
Sep 15, 2022
…/PyTorchLightning/metrics into bugfix/classwise_wrapper_forward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1220
Some of the logic in
_wrap_update
and_wrap_compute
was messing with thecompute
method in theClasswiseWrapper
. This PR makes them empty wrappers for that metric and also adds relevant testing.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃