Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concordance correlation coefficient #1201

Merged
merged 14 commits into from
Sep 26, 2022
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Aug 31, 2022

What does this PR do?

Fixes #1194
Adds concordance correlation coefficient to regression package.
Depends on changes made in #1200, which needs to be merged first.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added this to the v0.11 milestone Aug 31, 2022
@SkafteNicki SkafteNicki changed the title Newmetric/concordance Add concordance correlation coefficient Aug 31, 2022
@SkafteNicki SkafteNicki marked this pull request as ready for review September 23, 2022 10:29
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #1201 (fd05b31) into master (8f7b0e7) will decrease coverage by 50%.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1201     +/-   ##
========================================
- Coverage      86%     36%    -50%     
========================================
  Files         191     193      +2     
  Lines       11345   11375     +30     
========================================
- Hits         9727    4058   -5669     
- Misses       1618    7317   +5699     

@mergify mergify bot added the ready label Sep 23, 2022
@SkafteNicki SkafteNicki merged commit a0943fd into master Sep 26, 2022
@SkafteNicki SkafteNicki deleted the newmetric/concordance branch September 26, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Concordance Correlation Coefficient to metrics
3 participants