Classification Refactor [rebase & merge] #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1195 +/- ##
========================================
- Coverage 94% 86% -8%
========================================
Files 185 191 +6
Lines 8408 11310 +2902
========================================
+ Hits 7896 9691 +1795
- Misses 512 1619 +1107 |
Borda
force-pushed
the
devel/classification
branch
from
2d54eee to
27b4d93
Compare
Borda
added
enhancement
This was referenced Aug 28, 2022
Closed
Closed
* ranking * implementation * tests * init * docs * mypy * fix doctest * fix docs * try fix cpu half test * missing import
* some idea * implementation stuff * error message * somethings working * working * working multilabel precision recall * docstrings * working average precision * working roc * working auroc * working precision at recall * docs * init files * beginning doctest * more docs * more docs * more docs * more docs * more docs * more docs * correction to math * fix mypy * add suggestions * change default from 100 to None * fix * fix * some fixes * suggestions for stancld * try fixing * try fix * try again * more fixing * another fix * skip half + cpu test for old versions * fix link * another fix * nan safety * another fix * skip non working cpu half tests * skip non working cpu + half tests
* changes * some code * updates * working calibration * improve tests * docs * update * init files * docs calibration error * update * hinge loss * docs * fix type issue * fix * cast dtype * ci * skip non supported cpu half tests Co-authored-by: Jirka <[email protected]>
* micro to macro * new kl * deprecate old * move auc * move tests around * change import paths * update test path * change ref * Apply suggestions from code review Co-authored-by: Justus Schock <[email protected]> * update doctests * doctests fix Co-authored-by: Justus Schock <[email protected]>
* example * stat scores * revert * remove old tests * deprecate binned * remove init * warning functionals * docs update * add __new__ for class wrapping * update imports in docstrings * fix one mistake * fix doctests * Apply suggestions from code review * elif * kwargs * kwargs + elif * text * fix gpu testing Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Borda
force-pushed
the
devel/classification
branch
from
e3d3a34 to
ee4582a
Compare
* try * return Metric * fix top_k, average * assert * fixing * imports
SkafteNicki
approved these changes
Sep 13, 2022
Borda
approved these changes
Sep 13, 2022
Borda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1001 by @SkafteNicki
Following issues will additionally be closed (reason commented in each issue):
Fixes #304
Fixes #452
Fixes #530
Fixes #604
Fixes #613
Fixes #625
Fixes #655
Fixes #656
Fixes #663
Fixes #746
Fixes #782
Fixes #837
Fixes #935
Fixes #961
Fixes #1017
Fixes #1040
Fixes #1101
Fixes #1119
Fixes #1131
Fixes #1172
Fixes #1208
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
Remaining TODO:
__init__sDO NOT MERGE BEFORE ALL TODOS HAVE BEEN RESOLVED