[Refactor] Classification 4/n #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
added
enhancement
for more information, see https://pre-commit.ci
…hLightning/metrics into refactor/classification_4
for more information, see https://pre-commit.ci
…hLightning/metrics into refactor/classification_4
for more information, see https://pre-commit.ci
SkafteNicki
requested review from
edenlightning,
Borda,
justusschock,
tchaton,
ethanwharris and
SeanNaren
as code owners
Codecov Report
@@ Coverage Diff @@
## devel/classification #1151 +/- ##
======================================================
- Coverage 88% 53% -36%
======================================================
Files 185 185
Lines 9397 9513 +116
======================================================
- Hits 8301 5013 -3288
- Misses 1096 4500 +3404 |
4 tasks
justusschock
approved these changes
Jul 22, 2022
Borda
approved these changes
Jul 22, 2022
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This was referenced Jul 28, 2022
4 tasks
4 tasks
Borda
added a commit
that referenced
this pull request
Aug 26, 2022
* docs * update * hamming * working specificity * hamming base structure * init files for specificity * done with specificity * bit working hamming * working hamming * init files * docstring * specificity fix docs * fix float division * local/global * Apply suggestions from code review Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
4 tasks
Borda
added a commit
that referenced
this pull request
Sep 12, 2022
* docs * update * hamming * working specificity * hamming base structure * init files for specificity * done with specificity * bit working hamming * working hamming * init files * docstring * specificity fix docs * fix float division * local/global * Apply suggestions from code review Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Borda
added a commit
that referenced
this pull request
Sep 12, 2022
* docs * update * hamming * working specificity * hamming base structure * init files for specificity * done with specificity * bit working hamming * working hamming * init files * docstring * specificity fix docs * fix float division * local/global * Apply suggestions from code review Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Borda
added a commit
that referenced
this pull request
Sep 13, 2022
* docs * update * hamming * working specificity * hamming base structure * init files for specificity * done with specificity * bit working hamming * working hamming * init files * docstring * specificity fix docs * fix float division * local/global * Apply suggestions from code review Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Borda
added a commit
that referenced
this pull request
Sep 13, 2022
* docs * update * hamming * working specificity * hamming base structure * init files for specificity * done with specificity * bit working hamming * working hamming * init files * docstring * specificity fix docs * fix float division * local/global * Apply suggestions from code review Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continues work on classification refactor #1001
Prior work:
This PR takes care of
specificityandhamming_distancewhich are subclasses from the stat scores metric.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃