Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse _safe_matmul #1014

Merged
merged 2 commits into from
May 5, 2022
Merged

reuse _safe_matmul #1014

merged 2 commits into from
May 5, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented May 5, 2022 •
edited
Loading

What does this PR do?

Found there is one more cases of #1011

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug / fix Something isn't working label May 5, 2022
@Borda Borda enabled auto-merge (squash) May 5, 2022 14:28
@codecov
Copy link

codecov bot commented May 5, 2022 •
edited
Loading

Codecov Report

Merging #1014 (31987e4) into master (640c4d1) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1014   +/-   ##
======================================
- Coverage      95%     95%   -0%     
======================================
  Files         179     180    +1     
  Lines        7664    7668    +4     
======================================
  Hits         7274    7274           
- Misses        390     394    +4

@mergify mergify bot added the ready label May 5, 2022
@Borda Borda disabled auto-merge May 5, 2022 16:15
@Borda Borda merged commit 21384e5 into master May 5, 2022
@Borda Borda deleted the pt/next branch May 5, 2022 16:16
Borda added a commit that referenced this pull request May 5, 2022
@Borda
reuse _safe_matmul (#1014)
deb3655 
* additional `_safe_matmul`
* chlog

(cherry picked from commit 21384e5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@SkafteNicki SkafteNicki Awaiting requested review from SkafteNicki SkafteNicki is a code owner

@tchaton tchaton Awaiting requested review from tchaton

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

Assignees
No one assigned
Labels
bug / fix Something isn't working ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Borda @SeanNaren @justusschock