Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compute_on_step from detection #1005

Merged
merged 4 commits into from
May 5, 2022
Merged

Remove compute_on_step from detection #1005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fb184d
remove
SkafteNicki May 4, 2022
23913d5
Merge branch 'master' into cleanup/compute_on_step_detection
SkafteNicki May 5, 2022
eb96614
Merge branch 'master' into cleanup/compute_on_step_detection
mergify[bot] May 5, 2022
b8d1923
Merge branch 'master' into cleanup/compute_on_step_detection
Borda May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Removed deprecated `compute_on_step` argument in aggregation ([#990](https://github.com/PyTorchLightning/metrics/pull/990))


- Removed deprecated `compute_on_step` argument in detection ([#1005](https://github.com/PyTorchLightning/metrics/pull/1005))


- Removed deprecated `compute_on_step` argument in text ([#1004](https://github.com/PyTorchLightning/metrics/pull/1004))


- Removed deprecated `compute_on_step` argument in audio ([#1007](https://github.com/PyTorchLightning/metrics/pull/1007))



### Fixed

- Fixed multi device aggregation in `PearsonCorrCoef` ([#998](https://github.com/PyTorchLightning/metrics/pull/998))
Expand Down
9 changes: 1 addition & 8 deletions torchmetrics/detection/mean_ap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,12 +168,6 @@ class MeanAveragePrecision(Metric):
Else, please provide a list of ints.
class_metrics:
Option to enable per-class metrics for mAP and mAR_100. Has a performance impact.
compute_on_step:
Forward only calls ``update()`` and returns None if this is set to False.

.. deprecated:: v0.8
Argument has no use anymore and will be removed v0.9.

kwargs: Additional keyword arguments, see :ref:`Metric kwargs` for more info.

Example:
Expand Down Expand Up @@ -231,10 +225,9 @@ def __init__(
rec_thresholds: Optional[List[float]] = None,
max_detection_thresholds: Optional[List[int]] = None,
class_metrics: bool = False,
compute_on_step: Optional[bool] = None,
**kwargs: Dict[str, Any],
) -> None: # type: ignore
super().__init__(compute_on_step=compute_on_step, **kwargs)
super().__init__(**kwargs)

if not _TORCHVISION_GREATER_EQUAL_0_8:
raise ModuleNotFoundError(
Expand Down