Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Perceptual Path Length #1933

Closed
jxtngx opened this issue Jul 24, 2023 · 3 comments · Fixed by #1939
Closed

Add Perceptual Path Length #1933

jxtngx opened this issue Jul 24, 2023 · 3 comments · Fixed by #1939
Labels
enhancement New feature or request New metric

Comments

@jxtngx
Copy link
Contributor

jxtngx commented Jul 24, 2023

🚀 Feature

Add Perceptual Path Length (PPL) as described in this paper by NVIDIA:

A Style-Based Generator Architecture for Generative Adversarial Networks

Motivation

Add additional metrics to support the evaluation of generative models.

Pitch

Authors from Snap, ETH Zurich, and Carnegie Mellon used PyTorch Lightning in the following paper, but opted to use a metrics library other than torchmetrics. The only metric the authors needed that does not exist in torchmetrics is PPL.

Autodecoding Latent 3D Diffusion Models

@jxtngx jxtngx added the enhancement New feature or request label Jul 24, 2023
@github-actions
Copy link

Hi! thanks for your contribution!, great first issue!

@rasbt
Copy link

rasbt commented Jul 24, 2023

Sounds great! One thing to add here is that we probably don't want to name it PPL (but maybe PerceptualPathLength), otherwise it will be confused with the popular perplexity metric
Screenshot 2023-07-24 at 3 43 14 PM

@SkafteNicki
Copy link
Member

Hi @JustinGoheen, thanks for raising this issue.
We should definitly have this in torchmetrics. I try to look into it as soon as possible.
And agree with @rasbt that is should be PerceptualPathLength and not PPL. Usually we try to stick with long named, for example we use MeanSquaredError instead of MSE even if everyone in the universe agrees what the abbreviation stands for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request New metric
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants