Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metric: Perceptual Path Length #1939

Merged
merged 40 commits into from
Aug 9, 2023
Merged

New metric: Perceptual Path Length #1939

merged 40 commits into from
Aug 9, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 25, 2023

What does this PR do?

Fixes #1933

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1939.org.readthedocs.build/en/1939/

@SkafteNicki SkafteNicki added this to the v1.1.0 milestone Jul 25, 2023
@SkafteNicki SkafteNicki marked this pull request as ready for review August 3, 2023 12:13
@mergify mergify bot added the has conflicts label Aug 3, 2023
@mergify mergify bot removed the has conflicts label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1939 (e07de45) into master (5d977e9) will decrease coverage by 44%.
The diff coverage is 71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1939     +/-   ##
========================================
- Coverage      87%     43%    -44%     
========================================
  Files         266     268      +2     
  Lines       15280   15427    +147     
========================================
- Hits        13224    6603   -6621     
- Misses       2056    8824   +6768     

@mergify mergify bot added the has conflicts label Aug 7, 2023
@mergify mergify bot removed the has conflicts label Aug 8, 2023
@SkafteNicki
Copy link
Member Author

@Borda, @justusschock please re-review. After a second look at this, we already had a lot of the needed functionality already, so torch-fidelity is no longer needed for the implementation (only testing). A bit of code needed to be copied, but I have linked where needed to original implementation.

@Borda
Copy link
Member

Borda commented Aug 8, 2023

After a second look at this, we already had a lot of the needed functionality already, so torch-fidelity is no longer needed for the implementation (only testing). A bit of code needed to be copied, but I have linked where needed to original implementation.

I am fine with the code, my only concern is the dependency, can we somehow use the released package? what we really need form the master branch?

@SkafteNicki
Copy link
Member Author

After a second look at this, we already had a lot of the needed functionality already, so torch-fidelity is no longer needed for the implementation (only testing). A bit of code needed to be copied, but I have linked where needed to original implementation.

I am fine with the code, my only concern is the dependency, can we somehow use the released package? what we really need form the master branch?

It's no longer a dependency of this metric, only torchvision is needed.

But we need it for testing to compare against. And we specific need master because the addition of PPL in torch-fidelity happened after latest release

@Borda Borda enabled auto-merge (squash) August 8, 2023 13:29
@mergify mergify bot added the has conflicts label Aug 8, 2023
@mergify mergify bot removed the has conflicts label Aug 9, 2023
@mergify mergify bot added the ready label Aug 9, 2023
@Borda Borda merged commit 628ee1c into master Aug 9, 2023
@Borda Borda deleted the newmetric/ppl branch August 9, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Perceptual Path Length
3 participants