Apply suggestions from code review

Lightning-AI · Nov 30, 2021 · be20ddb · be20ddb
1 parent 7007705
commit be20ddb
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/torchmetrics/metric.py b/torchmetrics/metric.py
@@ -759,15 +759,9 @@ def compute(self) -> Any:
     @torch.jit.unused
     def forward(self, *args: Any, **kwargs: Any) -> Any:
 
-        if isinstance(self.metric_a, Metric):
-            val_a = self.metric_a(*args, **self.metric_a._filter_kwargs(**kwargs))
-        else:
-            val_a = self.metric_a
+        val_a = self.metric_a(*args, **self.metric_a._filter_kwargs(**kwargs)) if isinstance(self.metric_a, Metric) else self.metric_a
 
-        if isinstance(self.metric_b, Metric):
-            val_b = self.metric_b(*args, **self.metric_b._filter_kwargs(**kwargs))
-        else:
-            val_b = self.metric_b
+        val_b = self.metric_b(*args, **self.metric_b._filter_kwargs(**kwargs)) if isinstance(self.metric_b, Metric) else self.metric_b
 
         if val_a is None:
             # compute_on_step of metric_a is False