-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce PrecisionPlugin.forward_context()
#9988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
changed the title
introduce
Introduce Oct 18, 2021
PrecisionPlugin.forward_context()
PrecisionPlugin.forward_context()
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
October 18, 2021 12:13
tchaton
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
tchaton
approved these changes
Oct 18, 2021
carmocca
approved these changes
Oct 18, 2021
Co-authored-by: thomas chaton <[email protected]>
justusschock
approved these changes
Oct 18, 2021
rohitgr7
approved these changes
Oct 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #9988 +/- ##
=======================================
+ Coverage 89% 93% +4%
=======================================
Files 179 179
Lines 15830 15804 -26
=======================================
+ Hits 14056 14642 +586
+ Misses 1774 1162 -612 |
rohitgr7
pushed a commit
to Tshimanga/pytorch-lightning
that referenced
this pull request
Oct 18, 2021
Co-authored-by: thomas chaton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new method
forward_context
and simplifies duplicated implementations across inherited plugins fortrain_step_context
, etc.Part of #9987
Does your PR introduce any breaking changes? If yes, please list them.
No.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃