Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark trainer.config_validator as protected #9779

Merged
merged 4 commits into from
Oct 12, 2021
Merged

Mark trainer.config_validator as protected #9779

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed08497
Update trainer.py
ananthsub Oct 1, 2021
ef29d66
Update CHANGELOG.md
ananthsub Oct 1, 2021
a40d719
Merge branch 'master' into feat/mark-connector-protected
ananthsub Oct 1, 2021
4dbd17d
Merge branch 'master' into feat/mark-connector-protected
ananthsub Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pytorch_lightning/trainer/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ def __init__(
gpu_ids, tpu_cores = self._parse_devices(gpus, auto_select_gpus, tpu_cores)

# init connectors
self.config_validator = ConfigValidator(self)
self._config_validator = ConfigValidator(self)
ananthsub marked this conversation as resolved.
Show resolved Hide resolved
self.data_connector = DataConnector(self, multiple_trainloader_mode)
self.optimizer_connector = OptimizerConnector(self)

Expand Down Expand Up @@ -973,7 +973,7 @@ def _run(self, model: "pl.LightningModule") -> Optional[Union[_EVALUATE_OUTPUT,
if hasattr(model, "hparams"):
parsing.clean_namespace(model.hparams)

self.config_validator.verify_loop_configurations(model)
self._config_validator.verify_loop_configurations(model)

# attach model log function to callback
self.callback_connector.attach_model_logging_functions(model)
Expand Down