-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move block_ddp_sync_behaviour
to utilities
#9192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
force-pushed
the
refactor/block-sync
branch
from
August 30, 2021 00:11
45097d0
to
1a3026f
Compare
for more information, see https://pre-commit.ci
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
August 30, 2021 00:42
awaelchli
changed the title
Refactor/block sync
move Aug 30, 2021
block_ddp_sync_behaviour
to utilities
Codecov Report
@@ Coverage Diff @@
## master #9192 +/- ##
======================================
Coverage 92% 92%
======================================
Files 176 176
Lines 14860 14861 +1
======================================
+ Hits 13709 13710 +1
Misses 1151 1151 |
tchaton
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat !
carmocca
approved these changes
Aug 30, 2021
kaushikb11
reviewed
Aug 30, 2021
kaushikb11
approved these changes
Aug 30, 2021
Co-authored-by: Kaushik B <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves the context manager
block_ddp_sync_behaviour
in training loop to utilities. In addition:Part of #9191
Related (but not blocking each other): #9101
Does your PR introduce any breaking changes? If yes, please list them.
While this method was part of the public API, nobody can really effectively use it externally, so we don't consider this a breaking change at all.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃