-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing legacy profiler arg #9178
Merged
tchaton
merged 5 commits into
Lightning-AI:master
from
Tshimanga:feature/remove-1.5-legacy-profiler-argument
Aug 30, 2021
Merged
removing legacy profiler arg #9178
tchaton
merged 5 commits into
Lightning-AI:master
from
Tshimanga:feature/remove-1.5-legacy-profiler-argument
Aug 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tshimanga
commented
Aug 28, 2021
Tshimanga
commented
Aug 28, 2021
awaelchli
approved these changes
Aug 28, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9178 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 176 176
Lines 14877 14860 -17
=======================================
- Hits 13723 13093 -630
- Misses 1154 1767 +613 |
tchaton
approved these changes
Aug 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ! Thanks
Borda
reviewed
Aug 29, 2021
carmocca
approved these changes
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clean up PR that removes the legacy profiler argument
profiled_functions
. This is due for removal for v1.5If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
We discussed this in the slack channel.
The following links the related issue to the PR (https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)
-->
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃