-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove truncated_bptt_steps from Trainer constructor #8825
Merged
kaushikb11
merged 10 commits into
Lightning-AI:master
from
ananthsub:fix/validate-tbptt-difference
Aug 11, 2021
Merged
Remove truncated_bptt_steps from Trainer constructor #8825
kaushikb11
merged 10 commits into
Lightning-AI:master
from
ananthsub:fix/validate-tbptt-difference
Aug 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag was deprecated in v1.3 and is being removed in v1.5 The property has been moved to the LightningModule under the same property name
Codecov Report
@@ Coverage Diff @@
## master #8825 +/- ##
======================================
- Coverage 89% 89% -0%
======================================
Files 169 169
Lines 14069 14061 -8
======================================
- Hits 12463 12455 -8
Misses 1606 1606 |
awaelchli
approved these changes
Aug 10, 2021
awaelchli
reviewed
Aug 10, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
justusschock
approved these changes
Aug 10, 2021
carmocca
approved these changes
Aug 10, 2021
kaushikb11
approved these changes
Aug 11, 2021
four4fish
pushed a commit
to four4fish/pytorch-lightning
that referenced
this pull request
Aug 16, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This flag was deprecated in v1.3 and is being removed in v1.5
The property has been moved to the LightningModule under the same property name
This is a follow up to comments in #8804
Rather than validating that the trainer and lightning module values were the same if both were set, it's easier to remove the trainer settings altogether
Does your PR introduce any breaking changes? If yes, please list them.
Breaking change: Removed
truncated_bptt_steps
from Trainer constructorBefore submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃