Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override the logged epoch in logged_metrics #7982

Merged

Conversation

carmocca
Copy link
Contributor

What does this PR do?

  • Do not override the logged epoch if available.
  • Early return in log_metrics

Fixes #7882 (comment)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the feature Is an improvement or enhancement label Jun 15, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 15, 2021
@carmocca carmocca self-assigned this Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #7982 (37531d4) into master (d2983c7) will decrease coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7982    +/-   ##
=======================================
- Coverage      92%     91%    -0%     
=======================================
  Files         207     207            
  Lines       13380   13503   +123     
=======================================
+ Hits        12252   12330    +78     
- Misses       1128    1173    +45     

@carmocca carmocca changed the title Do not override the logged epoch Do not override the logged epoch in logged_metrics Jun 15, 2021
@awaelchli awaelchli added the logging Related to the `LoggerConnector` and `log()` label Jun 15, 2021
@carmocca carmocca added the ready PRs ready to be merged label Jun 15, 2021
@carmocca carmocca enabled auto-merge (squash) June 15, 2021 11:23
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot removed the has conflicts label Jun 16, 2021
@carmocca carmocca merged commit bc2c2db into master Jun 16, 2021
@carmocca carmocca deleted the refactor/logger-connector-do-not-add-epoch-if-available branch June 16, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants