[wip] Test removing hpc save/load

[ananthsub]

What does this PR do?

This is redundant with the existing model checkpoint save/load/resume functionality. we shouldn't have 2 paths in the codebase that do the same thing

sending out as a PR to see what breaks
Fixes #<issue_number>

Related issues: #6204, #5373

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

[ananthsub]

need to deprecate these hooks in favor of on_save/load_checkpoint

[codecov]

Codecov Report

Merging #7537 (5b9b77b) into master (233f252) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7537    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         196     195     -1     
  Lines       12835   12757    -78     
=======================================
- Hits        11832   11198   -634     
- Misses       1003    1559   +556     

[awaelchli]

the signal handling is not tested, so no surprise there are no failing tests.
But as you can see in the code below, this handles automatic job resubmission, and if you remove it, Lightning will lose support for this feature.

[ananthsub]

is it expected that lightning needs to natively handle automatic job resubmission? or does it make sense for this to be part of the application using Lightning to handle?

[tchaton]

Yes, it is expected and a pretty important feature of the Lightning framework :)

[ananthsub]

• would it make sense for this to be part of the SLURMEnvironment if users wanted to disable automatic resubmission?
• should resubmission be opt-in instead of opt-out?

[awaelchli]

would it make sense for this to be part of the SLURMEnvironment if users wanted to disable automatic resubmission?

yes
#6303

[williamFalcon]

@ananthsub yes... this is a very important feature and expected by lightning. let's keep this in the framework.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

[stale]

This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.