-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call any trainer function from the LightningCLI
#7508
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7508 +/- ##
======================================
Coverage 88% 88%
======================================
Files 176 176
Lines 14804 14857 +53
======================================
+ Hits 13032 13084 +52
- Misses 1772 1773 +1 |
This reverts commit 97a6628.
This is ready to go again, just waiting on a jsonargparse release with omni-us/jsonargparse#88 fixed (minor fix) Pinging reviewers: @tchaton @ethanwharris @mauvilsa @Borda @awaelchli (dismissed old reviews) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat !
63940e4
to
6ab08a1
Compare
6ab08a1
to
338f267
Compare
899cc6a
to
8d1c423
Compare
0a475af
to
620703b
Compare
What does this PR do?
Fixes #7226
Pitch
where
{fit,tune,validate,test,predict}
are all the available subcommands.The implementation needs to allow implementing custom subcommands. This will be useful in Flash to implement the
finetune
subcommand.A follow-up PR (out of scope for this one) could add subcommands which chain commands. Some potential examples would be
tune-and-fit
,fit-and-validate
, orfit-and-test
.Breaking changes
This change will be breaking for all previous CLI users. They will now need to pass the
fit
subcommand to keep the old behaviour. Any users who were adding subcommand already will need to update their position too.Before submitting
PR review