Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented train_datalaoder in data_connector, and reset_dataloader ex… #6103

Closed

Conversation

gianscarpe
Copy link
Contributor

…plicitely set train_dataloader from datamodule (if available). confg_validation checks if datamodule is available and eventually check datamodule.train_dataloader is overridden

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

…plicitely set train_dataloader from datamodule (if available). confg_validation checks if datamodule is available and eventually check datamodule.train_dataloader is overridden
@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #6103 (de60a3b) into master (0b27147) will decrease coverage by 60%.
The diff coverage is 8%.

@@           Coverage Diff            @@
##           master   #6103     +/-   ##
========================================
- Coverage      93%     33%    -60%     
========================================
  Files         160     160             
  Lines       11402   11304     -98     
========================================
- Hits        10654    3732   -6922     
- Misses        748    7572   +6824     

@pep8speaks
Copy link

Hello @gianscarpe! Thanks for updating this PR.

Line 209:121: E501 line too long (140 > 120 characters)

@stale
Copy link

stale bot commented Mar 8, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Mar 8, 2021
@stale
Copy link

stale bot commented Mar 15, 2021

This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.

@stale stale bot closed this Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
won't fix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants