Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple tests restructure #5452

Merged
merged 9 commits into from
Jan 16, 2021
Merged

simple tests restructure #5452

merged 9 commits into from
Jan 16, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 10, 2021

What does this PR do?

a bit move around test to proper folders, no test was dripped

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added ci Continuous Integration refactor labels Jan 10, 2021
@Borda Borda added this to the 1.2 milestone Jan 10, 2021
@Borda Borda enabled auto-merge (squash) January 10, 2021 22:46
@Borda Borda self-assigned this Jan 10, 2021
@Borda Borda added the ready PRs ready to be merged label Jan 11, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep the logging_test directory. Otherwise tools like PyCharm will try to load the logging directory instead of the logging module when you try to import it.

Also, when do we plan to remove the _1_0 suffixes?

What is the difference between the data_flow and legacy_deprecate_flow_log_tests?

@Borda
Copy link
Member Author

Borda commented Jan 11, 2021

please keep the logging_test directory. Otherwise tools like PyCharm will try to load the logging directory instead of the logging module when you try to import it.

pls see the actual state: https://github.com/PyTorchLightning/pytorch-lightning/tree/master/tests/trainer
there is already logging and logging_test so this is just merging them...

can you give an example of where we use in tests the base logging?
also, we shall use imports from ... import ... and then I do not see any problem

Also, when do we plan to remove the _1_0 suffixes?

maybe another PR...

What is the difference between the data_flow and legacy_deprecate_flow_log_tests?

lets ask author

I feel you are asking good question, but none of then are the goal of this PR (you/noone have not complained till I show it here), this just reveals what we have in code-base now and we shall clean step-by-step

@Borda
Copy link
Member Author

Borda commented Jan 11, 2021

@carmocca renamed to logging_process

@Borda Borda requested a review from carmocca January 11, 2021 13:57
@Borda Borda merged commit 2fe36c7 into release/1.2-dev Jan 16, 2021
@Borda Borda deleted the refactor/tests branch January 16, 2021 01:58
@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #5452 (0f1bca5) into release/1.2-dev (6386b8d) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/1.2-dev   #5452   +/-   ##
===============================================
  Coverage               93%     93%           
===============================================
  Files                  152     152           
  Lines                10736   10736           
===============================================
  Hits                  9948    9948           
  Misses                 788     788           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants