-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simple tests restructure #5452
simple tests restructure #5452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep the logging_test
directory. Otherwise tools like PyCharm will try to load the logging
directory instead of the logging
module when you try to import it.
Also, when do we plan to remove the _1_0
suffixes?
What is the difference between the data_flow
and legacy_deprecate_flow_log_tests
?
pls see the actual state: https://github.com/PyTorchLightning/pytorch-lightning/tree/master/tests/trainer can you give an example of where we use in tests the base logging?
maybe another PR...
lets ask author I feel you are asking good question, but none of then are the goal of this PR (you/noone have not complained till I show it here), this just reveals what we have in code-base now and we shall clean step-by-step |
@carmocca renamed to |
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5452 +/- ##
===============================================
Coverage 93% 93%
===============================================
Files 152 152
Lines 10736 10736
===============================================
Hits 9948 9948
Misses 788 788 |
What does this PR do?
a bit move around test to proper folders, no test was dripped
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃