-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checkpoint artifact path prefix to MLflow logger #20538
base: master
Are you sure you want to change the base?
Add checkpoint artifact path prefix to MLflow logger #20538
Conversation
Add a new `checkpoint_artifact_path_prefix` parameter to the MLflow logger. * Modify `src/lightning/pytorch/loggers/mlflow.py` to include the new parameter in the `MLFlowLogger` class constructor and use it in the `after_save_checkpoint` method. * Update the documentation in `docs/source-pytorch/visualize/loggers.rst` to include the new `checkpoint_artifact_path_prefix` parameter. * Add a new test in `tests/tests_pytorch/loggers/test_mlflow.py` to verify the functionality of the `checkpoint_artifact_path_prefix` parameter and ensure it is used in the artifact path. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Lightning-AI/pytorch-lightning?shareId=XXXX-XXXX-XXXX-XXXX).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot of the PR, I left a couple of comments but we're good to go.
Tests need fixing, can you take that @benglewis?
thank you @benglewis , happy to merge once tests are fixed |
@lantiga I have commit a change that fixes the test when I ran it with |
What does this PR do?
Introduces a new
checkpoint_artifact_path_prefix
argument toMLFlowLogger
which customizes the prefix for the model artifacts.Fixes #20540
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
Add a new
checkpoint_artifact_path_prefix
parameter to the MLflow logger.src/lightning/pytorch/loggers/mlflow.py
to include the new parameter in theMLFlowLogger
class constructor and use it in theafter_save_checkpoint
method.docs/source-pytorch/visualize/loggers.rst
to include the newcheckpoint_artifact_path_prefix
parameter.tests/tests_pytorch/loggers/test_mlflow.py
to verify the functionality of thecheckpoint_artifact_path_prefix
parameter and ensure it is used in the artifact path.For more details, open the Copilot Workspace session.
📚 Documentation preview 📚: https://pytorch-lightning--20538.org.readthedocs.build/en/20538/