-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump python 3.9+ #20413
bump python 3.9+ #20413
Conversation
for more information, see https://pre-commit.ci
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflowThese checks are required after the changes to 🟢 pytorch_lightning: Azure GPU
These checks are required after the changes to 🟢 pytorch_lightning: Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docker
These checks are required after the changes to 🟢 lightning_fabric: CPU workflowThese checks are required after the changes to 🟢 lightning_fabric: Azure GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to Thank you for your contribution! 💜
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20413 +/- ##
=======================================
Coverage 88% 88%
=======================================
Files 267 267
Lines 23203 23266 +63
=======================================
+ Hits 20313 20375 +62
- Misses 2890 2891 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8b8bb2e
to
7858262
Compare
crashing on MacOS for PT 2.1 |
should be mostly flaky, but I wonder if we should bump all pt 2.1 to 2.1.2, too. |
right, but the failing was quite consistent and happened quite often so we may consider doing a rerun...
do you mean but package dependency or just for testing/CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Borda
This is good to have, but let's merge the other things first to minimize the number of conflicts.
good call, let's hold it as the last one 🦩 |
What does this PR do?
Python 3.8 is not live, let's bump...
endoflife.date/python
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20413.org.readthedocs.build/en/20413/
cc @Borda @justusschock @awaelchli