fix(tests): update tests after torch 2.4.1 #20302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
lantiga,
tchaton and
justusschock
as code owners
github-actions
bot
added
fabric
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20302 +/- ##
=======================================
Coverage 89% 89%
=======================================
Files 267 267
Lines 23082 23084 +2
=======================================
+ Hits 20573 20585 +12
+ Misses 2509 2499 -10 |
for more information, see https://pre-commit.ci
Borda
changed the title
ethanwharris
approved these changes
Sep 26, 2024
Borda
added a commit
that referenced
this pull request
Sep 26, 2024
* update * test_loggers_pickle_all * more... * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit d1ca3c6)
lexierule
pushed a commit
that referenced
this pull request
Sep 27, 2024
* update * test_loggers_pickle_all * more... * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit d1ca3c6)
MrWhatZitToYaa
pushed a commit
to MrWhatZitToYaa/pytorch-lightning
that referenced
this pull request
Nov 20, 2024
* update * test_loggers_pickle_all * more... * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
seems some warnings were updated in the latest 2.4.1 and our tests rely on it
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20302.org.readthedocs.build/en/20302/