Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in _ResultCollection class comments #18534

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

0x404
Copy link
Contributor

@0x404 0x404 commented Sep 12, 2023

What does this PR do?

Fixes #18530

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--18534.org.readthedocs.build/en/18534/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #18534 (78af0e6) into master (e958c6f) will decrease coverage by 35%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18534      +/-   ##
==========================================
- Coverage      85%      50%     -35%     
==========================================
  Files         427      419       -8     
  Lines       33381    33235     -146     
==========================================
- Hits        28310    16699   -11611     
- Misses       5071    16536   +11465     

@awaelchli awaelchli changed the title fix a typo in _ResultCollection class comments Fix a typo in _ResultCollection class comments Sep 12, 2023
@awaelchli awaelchli merged commit 6dd6d73 into Lightning-AI:master Sep 12, 2023
@awaelchli awaelchli added docs Documentation related community This PR is from the community labels Sep 12, 2023
@awaelchli awaelchli added this to the 2.1 milestone Sep 12, 2023
@mergify mergify bot added the ready PRs ready to be merged label Sep 12, 2023
Borda pushed a commit that referenced this pull request Sep 14, 2023
lantiga pushed a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some outdated comments inconsistent with the code
3 participants