-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PKG: distribute single semver #15374
Conversation
ok, changed to have distributed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any assertion in CI to avoid distributing packages with the wrong version info? something like:
python -c "assert pl.__version__ == '${{ ... }}'"
good idea, we can also add in another PR, the if pypi release workflow is in action we would check if the generated version is the same as input git tag... |
007ecad
to
747c1e7
Compare
What does this PR do?
unify all pkg versions
in case you run from source without install provide commit hash
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @carmocca @akihironitta