-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AcceleratorConnector.tpu_id
#12387
Conversation
00026d5
to
7a8bf82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @DuYicong515! Left a couple of comments, looking forward to your thoughts on them. :)
2cf4b20
to
8fee629
Compare
a26e409
to
109a56c
Compare
109a56c
to
61d51d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clean up!
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work !
What does this PR do?
Part of #11449: deprecate unused properties in accelerator_connector: tpu_id
AccleratorConnector.tpu_id
was not used internally, and was not meant to be public. Remove it in favor of usingTrainer.device_ids
to check the TPU id when use TPU accelerator directly.Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃