Remove AcceleratorConnector.num_gpus
and deprecate Trainer.num_gpus
#12384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #11449 : remove unused properties in accelerator_connector: num_gpus
Part of #12171 : deprecate device related properties in Trainer that is accessed from accelerator_connector.
AcceleratorConnector.num_gpus
was not meant to be public. It's removed from AcceleratorConnector and deprecated in Trainer in favor of usingTrainer.num_devices if isinstance(Trainer.accelerator, GPUAccelerator) else 0
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃