Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AcceleratorConnector.num_nodes #12107

Merged
merged 7 commits into from
Feb 28, 2022

Conversation

DuYicong515
Copy link
Contributor

@DuYicong515 DuYicong515 commented Feb 25, 2022

What does this PR do?

Fixes #12082 (Suggested alternatives listed in the issue)
Part of #11449: deprecate unused properties in accelerator_connector

Does your PR introduce any breaking changes? If yes, please list them.

N/A

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [N/A] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • [N/A] Add labels and milestones (and optionally projects) to the PR so it can be classified

@DuYicong515 DuYicong515 force-pushed the refactor/num_nodes branch 2 times, most recently from fea1d01 to e48ed28 Compare February 25, 2022 01:55
@DuYicong515 DuYicong515 changed the title Remove AcceleratorConnector.num_nodes and deprecate Trainer.num_nodes Remove AcceleratorConnector.num_nodes Feb 26, 2022
tests/trainer/test_trainer.py Show resolved Hide resolved
@akihironitta akihironitta added this to the 1.6 milestone Feb 28, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Feb 28, 2022
@tchaton tchaton enabled auto-merge (squash) February 28, 2022 09:38
@tchaton tchaton merged commit c9af112 into Lightning-AI:master Feb 28, 2022
@DuYicong515 DuYicong515 deleted the refactor/num_nodes branch March 20, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AcceleratorConnector.num_nodes
6 participants