-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AcceleratorConnector.num_nodes
#12107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuYicong515
force-pushed
the
refactor/num_nodes
branch
2 times, most recently
from
February 25, 2022 01:55
fea1d01
to
e48ed28
Compare
ananthsub
reviewed
Feb 25, 2022
DuYicong515
changed the title
Remove
Remove Feb 26, 2022
AcceleratorConnector.num_nodes
and deprecate Trainer.num_nodes
AcceleratorConnector.num_nodes
DuYicong515
force-pushed
the
refactor/num_nodes
branch
from
February 26, 2022 01:16
6040e06
to
660a429
Compare
ananthsub
approved these changes
Feb 26, 2022
DuYicong515
commented
Feb 26, 2022
DuYicong515
requested review from
williamFalcon,
tchaton,
awaelchli,
SeanNaren,
carmocca,
Borda,
justusschock,
kaushikb11 and
rohitgr7
as code owners
February 26, 2022 01:23
awaelchli
approved these changes
Feb 27, 2022
carmocca
approved these changes
Feb 28, 2022
for more information, see https://pre-commit.ci
akihironitta
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12082 (Suggested alternatives listed in the issue)
Part of #11449: deprecate unused properties in accelerator_connector
Does your PR introduce any breaking changes? If yes, please list them.
N/A
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list: