Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_interactive_compatible logic after AcceleratorConnector rewrite #12008

Merged
merged 9 commits into from
Feb 22, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 19, 2022

What does this PR do?

Follow up to #11448
The PR introduced a bug with Jupyter notebooks because the strategy name property was changed. The check how it is implemented now doesn't make much sense.

#11970 proposes to move it to the strategy base class itself but my proposal here is to move it to the newly added launcher. IMO this fixes the issue more efficiently.

Notebook for manual checking.

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @tchaton @rohitgr7 @akihironitta @justusschock @kaushikb11 @awaelchli @ninginthecloud

@awaelchli awaelchli changed the title fix is_interactive_compatible logic after accelerator rewrite Fix is_interactive_compatible logic after accelerator rewrite Feb 19, 2022
@awaelchli awaelchli added bug Something isn't working trainer: connector labels Feb 19, 2022
@awaelchli awaelchli added this to the 1.6 milestone Feb 19, 2022
@awaelchli awaelchli added the priority: 0 High priority task label Feb 19, 2022
@awaelchli awaelchli marked this pull request as ready for review February 19, 2022 15:46
@awaelchli awaelchli changed the title Fix is_interactive_compatible logic after accelerator rewrite Fix is_interactive_compatible logic after AcceleratorConnector rewrite Feb 19, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth waiting until #11966 is merged so Adrian's comment can be addressed here

tests/accelerators/test_accelerator_connector.py Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged has conflicts labels Feb 21, 2022
@mergify mergify bot removed the has conflicts label Feb 21, 2022
@awaelchli awaelchli enabled auto-merge (squash) February 21, 2022 23:19
@mergify mergify bot removed the has conflicts label Feb 22, 2022
@awaelchli awaelchli requested a review from kaushikb11 February 22, 2022 12:54
@awaelchli awaelchli merged commit d0f5460 into master Feb 22, 2022
@awaelchli awaelchli deleted the bugfix/is_interactive_compatible branch February 22, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task ready PRs ready to be merged trainer: connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants