-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix is_interactive_compatible
logic after AcceleratorConnector rewrite
#12008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
changed the title
fix
Fix Feb 19, 2022
is_interactive_compatible
logic after accelerator rewriteis_interactive_compatible
logic after accelerator rewrite
awaelchli
commented
Feb 19, 2022
awaelchli
commented
Feb 19, 2022
10 tasks
awaelchli
requested review from
tchaton,
SeanNaren,
carmocca,
Borda,
justusschock,
kaushikb11,
williamFalcon and
rohitgr7
as code owners
February 19, 2022 15:46
awaelchli
changed the title
Fix
Fix Feb 19, 2022
is_interactive_compatible
logic after accelerator rewriteis_interactive_compatible
logic after AcceleratorConnector rewrite
12 tasks
four4fish
approved these changes
Feb 20, 2022
kaushikb11
approved these changes
Feb 21, 2022
carmocca
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth waiting until #11966 is merged so Adrian's comment can be addressed here
for more information, see https://pre-commit.ci
rohitgr7
approved these changes
Feb 22, 2022
kaushikb11
reviewed
Feb 22, 2022
kaushikb11
reviewed
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
priority: 0
High priority task
ready
PRs ready to be merged
trainer: connector
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #11448
The PR introduced a bug with Jupyter notebooks because the strategy name property was changed. The check how it is implemented now doesn't make much sense.
#11970 proposes to move it to the strategy base class itself but my proposal here is to move it to the newly added launcher. IMO this fixes the issue more efficiently.
Notebook for manual checking.
Does your PR introduce any breaking changes? If yes, please list them.
No.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @tchaton @rohitgr7 @akihironitta @justusschock @kaushikb11 @awaelchli @ninginthecloud