Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Trainer._strategy_type #11990

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Remove Trainer._strategy_type #11990

merged 4 commits into from
Feb 21, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 18, 2022

What does this PR do?

Part of #11449

Does your PR introduce any breaking changes? If yes, please list them.

Removes the protected _strategy_type.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7 @akihironitta

@carmocca carmocca added this to the 1.6 milestone Feb 18, 2022
@carmocca carmocca self-assigned this Feb 18, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 18, 2022
tests/trainer/test_trainer.py Show resolved Hide resolved
@ananthsub ananthsub enabled auto-merge (squash) February 18, 2022 17:06
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ananthsub ananthsub merged commit 0771a55 into master Feb 21, 2022
@ananthsub ananthsub deleted the refactor/remove_strategy_type branch February 21, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor strategy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants