Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Save only the configuration used #11532

Merged
merged 4 commits into from
Jan 20, 2022
Merged

[CLI] Save only the configuration used #11532

merged 4 commits into from
Jan 20, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 18, 2022

What does this PR do?

Fixes #11463

Does your PR introduce any breaking changes? If yes, please list them.

The saved config format changes so this would be a breaking change if somebody relied on it.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @mauvilsa

@carmocca carmocca changed the title [CLI] Save only the used configuration [CLI] Save only the configuration used Jan 19, 2022
@carmocca carmocca enabled auto-merge (squash) January 19, 2022 15:30
@awaelchli
Copy link
Contributor

The linked issue is the wrong one. There must be a typo :)

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Jan 20, 2022
@carmocca carmocca merged commit 7295457 into master Jan 20, 2022
@carmocca carmocca deleted the bug/cli-config branch January 20, 2022 12:35
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lightningcli pl.cli.LightningCLI ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI] Can't launch test command from checkpoint because "fit" key added to top level of CLI config
4 participants