Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid in-place ops during logging result updates #11401

Merged
merged 6 commits into from
Jan 12, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 10, 2022

What does this PR do?

Fixes #11386

This is caused by:

import torch

a = torch.tensor(0.0, dtype=torch.float)
b = torch.tensor(3.0, dtype=torch.double)

a = a + b  # same as `a.add(b)`
# `a` promoted to double
assert a.dtype is torch.double

a = torch.tensor(0.0, dtype=torch.float)  # reset dtype

a += b  # same as `a.add_(b)`
# `a` NOT promoted to double
assert a.dtype is torch.float

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @tchaton @rohitgr7 @carmocca @edward-io @ananthsub @kamil-kaczmarek @Raalsky @Blaizzy

@carmocca carmocca added priority: 0 High priority task logging Related to the `LoggerConnector` and `log()` labels Jan 10, 2022
@carmocca carmocca added this to the 1.5.x milestone Jan 10, 2022
@carmocca carmocca self-assigned this Jan 10, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 11, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) January 11, 2022 08:49
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #11401 (65ff90d) into master (948cfd2) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #11401    +/-   ##
========================================
- Coverage      92%      88%    -4%     
========================================
  Files         194      194            
  Lines       16936    16981    +45     
========================================
- Hits        15555    14964   -591     
- Misses       1381     2017   +636     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rohitgr7 rohitgr7 merged commit f5bbc2c into master Jan 12, 2022
@rohitgr7 rohitgr7 deleted the bugfix/logging-inpalce branch January 12, 2022 08:09
carmocca added a commit that referenced this pull request Jan 12, 2022
lexierule pushed a commit that referenced this pull request Jan 19, 2022
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging Related to the `LoggerConnector` and `log()` priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use float64 instead of float32 in logger & metric & result
6 participants