Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Warning in PredictionEpochLoop #11189

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Suppress Warning in PredictionEpochLoop #11189

merged 2 commits into from
Dec 21, 2021

Conversation

borchero
Copy link
Contributor

@borchero borchero commented Dec 21, 2021

What does this PR do?

This PR gets rid of a warning that is emitted every time on_run_start is run on the PredictionEpochLoop. At the time of the call to _get_batch_indices, the parameter return_predictions passed to on_run_start has not been set and the following warning is emitted in any case: "Lightning couldn't infer the indices fetched for your dataloader."

-- no issue opened

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added this to the 1.5.x milestone Dec 21, 2021
@mergify mergify bot added the ready PRs ready to be merged label Dec 21, 2021
@mergify mergify bot requested a review from a team December 21, 2021 14:05
@rohitgr7 rohitgr7 enabled auto-merge (squash) December 21, 2021 14:07
@rohitgr7 rohitgr7 merged commit 17aceaf into Lightning-AI:master Dec 21, 2021
awaelchli pushed a commit that referenced this pull request Dec 21, 2021
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
lexierule pushed a commit that referenced this pull request Dec 21, 2021
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged trainer: predict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants