Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError when using CombinedLoader in prediction #11111

Merged
merged 7 commits into from
Dec 17, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 16, 2021

What does this PR do?

Fixes #11062

This is a partial fix to enable prediction with CombinedLoader without tracked sample indices until we figure out how we support batch_sampler with CombinedLoader.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @justusschock @awaelchli @ninginthecloud

@awaelchli awaelchli added bug Something isn't working data handling Generic data-related topic trainer: predict labels Dec 16, 2021
@awaelchli awaelchli added this to the 1.5.x milestone Dec 16, 2021
@awaelchli awaelchli changed the title Fix AttributeError when using CombinedDataLoader in prediction Fix AttributeError when using CombinedLoader in prediction Dec 16, 2021
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Dec 17, 2021
@awaelchli awaelchli enabled auto-merge (squash) December 17, 2021 16:55
@awaelchli awaelchli merged commit 978f5e6 into master Dec 17, 2021
@awaelchli awaelchli deleted the bugfix/combined-predict-dataloader branch December 17, 2021 18:02
rohitgr7 pushed a commit that referenced this pull request Dec 18, 2021
lexierule pushed a commit that referenced this pull request Dec 21, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data handling Generic data-related topic ready PRs ready to be merged trainer: predict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'CombinedLoader' object has no attribute 'batch_sampler' when using a CombinedLoader in predict_dataloader
5 participants