Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teardown sync-batchnorm after training #11078

Merged
merged 12 commits into from
Dec 16, 2021
Merged

Teardown sync-batchnorm after training #11078

merged 12 commits into from
Dec 16, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 15, 2021 •
edited by github-actions bot
Loading

What does this PR do?

Attempt to fix #11076

I'm checking whether pytorch/pytorch#41081 (comment) is a viable solution. If it is, support for it could be added in upstream PyTorch.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @justusschock @kaushikb11 @awaelchli @akihironitta

@awaelchli awaelchli changed the title teardown sync batchnorm after training Teardown sync-batchnorm after training Dec 15, 2021
@awaelchli awaelchli added bug Something isn't working strategy: ddp DistributedDataParallel strategy: ddp spawn labels Dec 15, 2021
@awaelchli awaelchli added this to the 1.5.x milestone Dec 15, 2021
@awaelchli awaelchli marked this pull request as ready for review December 15, 2021 16:44
ananthsub
ananthsub approved these changes Dec 16, 2021
View reviewed changes
pytorch_lightning/utilities/distributed.py Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Dec 16, 2021
@awaelchli awaelchli enabled auto-merge (squash) December 16, 2021 18:03
@awaelchli awaelchli merged commit 2b0075a into master Dec 16, 2021
@awaelchli awaelchli deleted the bugfix/teardown-sync-batchnorm branch December 16, 2021 18:58
awaelchli added a commit that referenced this pull request Dec 16, 2021
@awaelchli @pre-commit-ci
@ananthsub @carmocca
Teardown sync-batchnorm after training (#11078)
63b6bc3 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
awaelchli added a commit that referenced this pull request Dec 17, 2021
@awaelchli @pre-commit-ci
@ananthsub @carmocca
Teardown sync-batchnorm after training (#11078)
753861a 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@awaelchli awaelchli mentioned this pull request Dec 20, 2021
Closed
lexierule pushed a commit that referenced this pull request Dec 21, 2021
@awaelchli @pre-commit-ci
@ananthsub @carmocca @lexierule
Teardown sync-batchnorm after training (#11078)
acb3846 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ananthsub <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananthsub ananthsub ananthsub approved these changes

@carmocca carmocca carmocca approved these changes

@justusschock justusschock justusschock approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged strategy: ddp DistributedDataParallel
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.

model.to_torchscript can not process the model trained with sync_batchnorm
4 participants
@awaelchli @ananthsub @carmocca @justusschock