Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for logging within callbacks returned from LightningModule #10991

Merged
merged 11 commits into from
Dec 14, 2021
Merged

Fix support for logging within callbacks returned from LightningModule #10991

merged 11 commits into from
Dec 14, 2021

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Dec 8, 2021 •
edited by github-actions bot
Loading

What does this PR do?

The logging support for callbacks is added before the callbacks from LightningModule are configured. The PR fixes that.
Also added a small support of returning a single callback from LightningModule.configure_callbacks rather than a list always.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Part of #1

cc @Borda @awaelchli @ananthsub @daniellepintz @carmocca @edward-io

@rohitgr7 rohitgr7 added callback logging Related to the `LoggerConnector` and `log()` labels Dec 8, 2021
@rohitgr7 rohitgr7 added this to the 1.5.x milestone Dec 8, 2021
@rohitgr7 rohitgr7 self-assigned this Dec 8, 2021
@rohitgr7 rohitgr7 marked this pull request as ready for review December 8, 2021 10:49
@Lightning-AI Lightning-AI deleted a comment from github-actions bot Dec 8, 2021
@rohitgr7 rohitgr7 modified the milestones: 1.5.x, 1.6 Dec 8, 2021
tchaton
tchaton approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch !

tests/trainer/connectors/test_callback_connector.py Outdated Show resolved Hide resolved
@awaelchli
Copy link
Contributor

Also added a small support of returning a single callback from LightningModule.configure_callbacks rather than a list always.

This would have to be a separate PR. We want to include only the fix in the bugfix release.

@awaelchli awaelchli added the bug Something isn't working label Dec 14, 2021
@mergify mergify bot removed the has conflicts label Dec 14, 2021
@mergify mergify bot added the ready PRs ready to be merged label Dec 14, 2021
@carmocca carmocca merged commit 61a744f into master Dec 14, 2021
@carmocca carmocca deleted the fix/lm_cb_log branch December 14, 2021 18:41
rohitgr7 added a commit that referenced this pull request Dec 14, 2021
@rohitgr7 @tchaton @carmocca
Fix support for logging within callbacks returned from `LightningModu…
dc706e0 
…le` (#10991)

Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: Carlos Mocholi <[email protected]>
lexierule pushed a commit that referenced this pull request Dec 15, 2021
@rohitgr7 @tchaton
@carmocca @lexierule
Fix support for logging within callbacks returned from `LightningModu…
ccfd1d8 
…le` (#10991)

Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: Carlos Mocholi <[email protected]>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@rohitgr7 rohitgr7

Labels
bug Something isn't working callback logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.
4 participants
@rohitgr7 @awaelchli @carmocca @tchaton