Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlinks in docs #10739

Merged
merged 4 commits into from
Dec 2, 2021
Merged

Fix deadlinks in docs #10739

merged 4 commits into from
Dec 2, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Nov 24, 2021

What does this PR do?

Ran deadlink on Lightning docs

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@kaushikb11 kaushikb11 requested a review from carmocca as a code owner November 25, 2021 05:32
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Dec 1, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking can we have a job that would test all ink to be active?

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaushikb11 Added some suggestions for fairscale that should work. Don't think it can be done for graphcore as those links aren't listed in the intersphinx inventory on their docs :/

docs/source/advanced/advanced_gpu.rst Outdated Show resolved Hide resolved
docs/source/advanced/advanced_gpu.rst Outdated Show resolved Hide resolved
@kaushikb11 kaushikb11 added this to the 1.5.x milestone Dec 2, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) December 2, 2021 08:45
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #10739 (a8d3454) into master (0066ff0) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #10739    +/-   ##
========================================
- Coverage      92%      92%    -0%     
========================================
  Files         177      177            
  Lines       16397    16554   +157     
========================================
+ Hits        15053    15192   +139     
- Misses       1344     1362    +18     

@kaushikb11 kaushikb11 merged commit 541b983 into master Dec 2, 2021
@kaushikb11 kaushikb11 deleted the fix/deadlinks branch December 2, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants