Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the auto-cc bot #10531

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Enable the auto-cc bot #10531

merged 2 commits into from
Nov 15, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 14, 2021

What does this PR do?

Fixes #9216
Uses #10530

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added feature Is an improvement or enhancement ci Continuous Integration labels Nov 14, 2021
@carmocca carmocca added this to the 1.6 milestone Nov 14, 2021
@carmocca carmocca self-assigned this Nov 14, 2021
@carmocca carmocca marked this pull request as draft November 14, 2021 22:11
@carmocca carmocca added lightningcli pl.cli.LightningCLI and removed lightningcli pl.cli.LightningCLI labels Nov 14, 2021
@carmocca carmocca added lightningcli pl.cli.LightningCLI and removed lightningcli pl.cli.LightningCLI labels Nov 15, 2021
@carmocca carmocca marked this pull request as ready for review November 15, 2021 01:59
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot requested a review from a team November 15, 2021 09:51
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #10531 (b6b603a) into master (7a9a08c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10531   +/-   ##
=======================================
  Coverage      93%      93%           
=======================================
  Files         178      178           
  Lines       16198    16198           
=======================================
  Hits        14989    14989           
  Misses       1209     1209           

@carmocca carmocca enabled auto-merge (squash) November 15, 2021 14:15
@mergify mergify bot added the ready PRs ready to be merged label Nov 15, 2021
@carmocca carmocca merged commit 3077886 into master Nov 15, 2021
@carmocca carmocca deleted the ci/probot-auto-cc branch November 15, 2021 14:27
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue Label Notifications by using GitHub Action
5 participants