log metrics for correct dataloader only #10522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…pytorch-lightning into bugfix/logger-mixup-dataloaders
shabie
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
justusschock
requested changes
Nov 15, 2021
pytorch_lightning/trainer/connectors/logger_connector/logger_connector.py
Outdated
Show resolved
Hide resolved
justusschock
approved these changes
Nov 15, 2021
carmocca
reviewed
Nov 15, 2021
Co-authored-by: Carlos Mocholí <[email protected]>
shabie
commented
Nov 15, 2021
kaushikb11
approved these changes
Nov 18, 2021
|
Cool test case with |
|
Thanks! And thank you for contributing. Hope to see more of your work 💜 |
|
I loved it and hoping to dive deeper. So much to learn for me to learn from
guys like you. Thank you for being patient and see you soon again :)
…On Fri, Nov 19, 2021, 00:30 Carlos Mocholí ***@***.***> wrote:
Thanks! And thank you for contributing. Hope to see more of your work 💜
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10522 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHI632RRXVZIAVG366REOKLUMWD77ANCNFSM5H7LVFAA>
.
|
rohitgr7
pushed a commit
that referenced
this pull request
Nov 22, 2021
Co-authored-by: tchaton <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]>
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
Co-authored-by: tchaton <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]>
awaelchli
pushed a commit
that referenced
this pull request
Nov 24, 2021
Co-authored-by: tchaton <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Nov 24, 2021
Co-authored-by: tchaton <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10494
Before submitting
Did you have fun?
I totally did and may do more of this :)