Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate DistributedType in favor of StrategyType #10505

Merged
merged 14 commits into from
Nov 15, 2021
Merged

Deprecate DistributedType in favor of StrategyType #10505

merged 14 commits into from
Nov 15, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Nov 12, 2021 •
edited
Loading

What does this PR do?

Part of #9932

Kudos to @ethanwharris for sharing the Enum deprecation trick! 🥳

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added this to the 1.6 milestone Nov 12, 2021
@kaushikb11 kaushikb11 mentioned this pull request Nov 12, 2021
Closed
16 tasks
@kaushikb11 kaushikb11 marked this pull request as draft November 12, 2021 13:37
@kaushikb11 kaushikb11 added the deprecation Includes a deprecation label Nov 12, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review November 12, 2021 13:51
@kaushikb11 kaushikb11 changed the title Rename DistributedType Enum to StrategyType Deprecate DistributedType in favor of StrategyType Nov 12, 2021
ethanwharris
ethanwharris approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 😃

@kaushikb11 kaushikb11 enabled auto-merge (squash) November 12, 2021 13:58
@kaushikb11 kaushikb11 mentioned this pull request Nov 12, 2021
Merged
12 tasks
carmocca
carmocca reviewed Nov 12, 2021
View reviewed changes
pytorch_lightning/utilities/enums.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/enums.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/enums.py Outdated Show resolved Hide resolved
rohitgr7
rohitgr7 approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are still some instances of it left inside dqn example inside notebooks..

pytorch_lightning/utilities/enums.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 12, 2021
carmocca
carmocca approved these changes Nov 12, 2021
View reviewed changes
pytorch_lightning/utilities/enums.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/enums.py Outdated Show resolved Hide resolved
@four4fish four4fish mentioned this pull request Nov 12, 2021
Closed
@four4fish
Copy link
Contributor

Great! Thank you for fixing this.
One big step towards #10422

tchaton
tchaton approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/utilities/enums.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/enums.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/enums.py Show resolved Hide resolved
carmocca
carmocca previously requested changes Nov 15, 2021
View reviewed changes
tests/trainer/test_trainer.py Show resolved Hide resolved
@mergify mergify bot removed the 0:] Ready-To-Go label Nov 15, 2021
@mergify mergify bot removed the ready PRs ready to be merged label Nov 15, 2021
@carmocca carmocca dismissed their stale review November 15, 2021 14:22

i'm dumb

@mergify mergify bot added the ready PRs ready to be merged label Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 15, 2021 •
edited
Loading

Codecov Report

Merging #10505 (8a29ecb) into master (fa0ed17) will increase coverage by 0%.
The diff coverage is 90%.

@@           Coverage Diff           @@
##           master   #10505   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         179      178    -1     
  Lines       16288    16226   -62     
=======================================
- Hits        15060    15009   -51     
+ Misses       1228     1217   -11

@kaushikb11 kaushikb11 merged commit 01cf7a2 into master Nov 15, 2021
@kaushikb11 kaushikb11 deleted the rename/distributed_type branch November 15, 2021 17:10
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@kaushikb11 @Raalsky
Deprecate DistributedType in favor of StrategyType (Lightning-AI#…
0e93102 
…10505)
@Borda Borda mentioned this pull request Mar 9, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@tchaton tchaton tchaton approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@carmocca carmocca carmocca left review comments

@awaelchli awaelchli Awaiting requested review from awaelchli

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
deprecation Includes a deprecation ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
6 participants
@kaushikb11 @four4fish @ethanwharris @carmocca @tchaton @rohitgr7