Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved env_vars_connector._defaults_from_env_vars to utilities.argsparse._defaults_from_env_vars #10501

Merged
merged 10 commits into from
Nov 22, 2021
Merged

Moved env_vars_connector._defaults_from_env_vars to utilities.argsparse._defaults_from_env_vars #10501

merged 10 commits into from
Nov 22, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Nov 12, 2021 •
edited by daniellepintz
Loading

What does this PR do?

Part of #10417
Fixes #10161

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @akihironitta @tchaton

@kaushikb11 kaushikb11 added deprecation Includes a deprecation refactor labels Nov 12, 2021
@kaushikb11 kaushikb11 added this to the 1.6 milestone Nov 12, 2021
@kaushikb11 kaushikb11 changed the title Move _default_from_env_vars from env_vars_connector to utils Deprecated trainer.connectors.env_vars_connector._defaults_from_env_vars in favor of utilities.argsparse._defaults_from_env_vars Nov 12, 2021
@kaushikb11 kaushikb11 changed the title Deprecated trainer.connectors.env_vars_connector._defaults_from_env_vars in favor of utilities.argsparse._defaults_from_env_vars Deprecated env_vars_connector._defaults_from_env_vars in favor of utilities.argsparse._defaults_from_env_vars Nov 12, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review November 12, 2021 10:59
tchaton
tchaton approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/trainer/connectors/env_vars_connector.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Nov 18, 2021
@kaushikb11 kaushikb11 changed the title Deprecated env_vars_connector._defaults_from_env_vars in favor of utilities.argsparse._defaults_from_env_vars Moved env_vars_connector._defaults_from_env_vars to utilities.argsparse._defaults_from_env_vars Nov 18, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) November 18, 2021 19:40
@mergify mergify bot added the ready PRs ready to be merged label Nov 18, 2021
daniellepintz
daniellepintz approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@daniellepintz daniellepintz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mergify mergify bot removed the has conflicts label Nov 19, 2021
@mergify mergify bot removed the has conflicts label Nov 22, 2021
@kaushikb11 kaushikb11 merged commit ce0a977 into master Nov 22, 2021
@kaushikb11 kaushikb11 deleted the refactor/default_env_vars branch November 22, 2021 08:06
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@kaushikb11 @carmocca @Raalsky
Moved env_vars_connector._defaults_from_env_vars to `utilities.args…
daa1544 
…parse._defaults_from_env_vars` (Lightning-AI#10501)

Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta left review comments

@carmocca carmocca carmocca left review comments

@daniellepintz daniellepintz daniellepintz approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
deprecation Includes a deprecation ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

Move env_vars_connector.py to utilities file
7 participants
@kaushikb11 @awaelchli @carmocca @tchaton @akihironitta @rohitgr7 @daniellepintz