Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve workers being forcelly deleted with persistent_workers=True #10434

Merged
merged 7 commits into from
Nov 9, 2021
Merged

Resolve workers being forcelly deleted with persistent_workers=True #10434

merged 7 commits into from
Nov 9, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 9, 2021 •
edited
Loading

What does this PR do?

Fixes #9390

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added the bug Something isn't working label Nov 9, 2021
@tchaton tchaton added this to the 1.5.x milestone Nov 9, 2021
@tchaton tchaton self-assigned this Nov 9, 2021
@tchaton tchaton added the priority: 0 High priority task label Nov 9, 2021
@tchaton tchaton changed the title Resolve workers being forcelly deleted Resolve workers being forcelly deleted with persistent_workers=True Nov 9, 2021
kaushikb11
kaushikb11 approved these changes Nov 9, 2021
View reviewed changes
tests/loops/test_loops.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 9, 2021
@justusschock justusschock enabled auto-merge (squash) November 9, 2021 13:22
@kaushikb11
Copy link
Contributor

Let's be careful about the first commit message for the PR. You could update it

@carmocca carmocca enabled auto-merge (squash) November 9, 2021 13:56
@mergify mergify bot added the has conflicts label Nov 9, 2021
@mergify mergify bot removed the has conflicts label Nov 9, 2021
@awaelchli awaelchli mentioned this pull request Nov 9, 2021
Merged
11 tasks
@carmocca carmocca merged commit 7fb277f into master Nov 9, 2021
@carmocca carmocca deleted the resolve_persistent_workers branch November 9, 2021 14:58
awaelchli added a commit that referenced this pull request Nov 9, 2021
@awaelchli
Resolve workers being forcelly deleted with persistent_workers=True (…
2c7202f 
…#10434)
awaelchli added a commit that referenced this pull request Nov 9, 2021
@awaelchli @tchaton
Resolve workers being forcelly deleted with persistent_workers=True (…
b427fdf 
…#10434)

Co-authored-by: Thomas Chaton <[email protected]>
@cowwoc cowwoc mentioned this pull request Nov 9, 2021
Closed
lexierule pushed a commit that referenced this pull request Nov 9, 2021
@awaelchli @tchaton @lexierule
Resolve workers being forcelly deleted with persistent_workers=True (…
51cb077 
…#10434)

Co-authored-by: Thomas Chaton <[email protected]>
@carmocca carmocca mentioned this pull request Nov 10, 2021
Closed
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@tchaton @carmocca @Raalsky
Resolve workers being forcelly deleted with persistent_workers=True (…
7b8a91a 
…Lightning-AI#10434)

Co-authored-by: Carlos Mocholi <[email protected]>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@justusschock justusschock justusschock approved these changes

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.

Ability to release resources associated with a DataLoader
5 participants
@tchaton @kaushikb11 @carmocca @justusschock @rohitgr7